Replace loops with memcpy/memmove/memset in bitsetasshortlong.h#124172
Closed
Replace loops with memcpy/memmove/memset in bitsetasshortlong.h#124172
Conversation
Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace loops with memset/memmove in bitsetasshortlong.h
Replace loops with memcpy/memmove/memset in bitsetasshortlong.h
Feb 9, 2026
Member
|
Some visible improvements in TP, but it's possible because of the retired-instruction metric + we don't use Native PGO |
This was referenced Feb 9, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diffs
Description
Replaces element-wise loops with bulk memory operations in three bitset functions for better performance and code clarity.
Changes
memmove()instead of loop (handles potential overlap)memcpy()instead of loop (destination is freshly allocated)memset()instead of zero-initialization loopAll functions operate on
size_t*arrays wherelen = BitSetTraits::GetArrSize(env). Standard library functions are available viajitpch.h.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.